Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update logger #372

Merged
merged 6 commits into from
Jul 23, 2024
Merged

refactor: Update logger #372

merged 6 commits into from
Jul 23, 2024

Conversation

hahwul
Copy link
Member

@hahwul hahwul commented Jul 21, 2024 •
edited
Loading

스크린샷 2024-07-22 오후 11 56 05

@hahwul hahwul linked an issue Jul 21, 2024 that may be closed by this pull request
Improve logger style #371
Closed
@hahwul hahwul self-assigned this Jul 21, 2024
@hahwul hahwul added this to the v0.17.0 milestone Jul 21, 2024
@hahwul hahwul changed the title refactor: Update logger prefixes to use Unicode symbols refactor: Update logger Jul 21, 2024
@hahwul hahwul changed the title refactor: Update logger refactor: Update logger and Add verbose flag Jul 21, 2024
@hahwul hahwul changed the title refactor: Update logger and Add verbose flag refactor: Update logger Jul 22, 2024
@github-actions github-actions bot added 🔬 analyzer Issue for Analyzer 💌 deliver Issue for Deliver labels Jul 22, 2024
@hahwul hahwul marked this pull request as ready for review July 22, 2024 14:36
@hahwul
Copy link
Member Author

hahwul commented Jul 22, 2024

Hi @ksg97031
The log style has been changed. Here is the updated version

app.logger.info "This is info log."
app.logger.sub "This is sub log."
app.logger.success "This is success log."
app.logger.warning "This is warning log."
app.logger.error "This is error log."
app.logger.debug "This is debug log."
app.logger.debug_sub "This is debug sub log."
app.logger.fatal "This is fatal log."

@hahwul hahwul requested a review from ksg97031 July 22, 2024 15:03
ksg97031
ksg97031 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ksg97031 ksg97031 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hahwul
I like all the changes. Great job!!

@ksg97031 ksg97031 merged commit 0731a14 into dev Jul 23, 2024
9 checks passed
@hahwul hahwul deleted the improve-logger branch July 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksg97031 ksg97031 ksg97031 approved these changes

Assignees

@hahwul hahwul

Labels
🔬 analyzer Issue for Analyzer 💌 deliver Issue for Deliver
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Improve logger style
2 participants
@hahwul @ksg97031